refactor: set controller pattern to bottom sheet#463
Open
tvillega wants to merge 18 commits intoeddyizm:developmentfrom
Open
refactor: set controller pattern to bottom sheet#463tvillega wants to merge 18 commits intoeddyizm:developmentfrom
tvillega wants to merge 18 commits intoeddyizm:developmentfrom
Conversation
In order to add a toolbar with a back button in settings I needed to extend from a fragment so I converted SettingsFragment into a fragment and created SettingsContainerFragment, the latter is injected as a child of SettingsFragment inside a FrameLayout. Since SettingsContainerFragment extends from PreferenceFragmentCompat, this allows to swap it for other and, in the bigger picture, allow an arbitrary organization.
This reverts commit eeb1255.
This reverts commit 34d354d.
This reverts commit 52cfd36.
Hide bottom navigation bar on portrait and unlock drawer on portrait
…attern-to-navigation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #460, see its description for context.
Up to this point, the navigation and the bottom sheet (the music player) have been mostly detached from the MainActivity, using now setters/getters and not global variables to interact with them.
The legacy code still interacts directly with MainActivity, but the functions are wrappers that communicate directly with the controllers. The pending functions mix the navigation with the bottom sheet so I wasn't able to wrap them properly.
I need to figure out how to make the controllers talk directly with each other, right now they use the global variables of MainActivity to achieve it.
The app keeps working normally and the legibility of the code has improved dramatically.